feat: argument to disable linting of `(` for auto-printing #2919

TimTaylor · 2025-08-04T18:24:43Z

Adds an argument to implicit_assignment_linter to disable linting of ( for auto-printing.
closes #2916

MichaelChirico · 2025-08-04T18:26:08Z

NEWS.md

 * `object_usage_linter()` lints missing packages that may cause false positives (#2872, @AshesITR)
 * New argument `include_s4_slots` for the `xml_find_function_calls()` entry in the `get_source_expressions()` to govern whether calls of the form `s4Obj@fun()` are included in the result (#2820, @MichaelChirico).
 * `sprintf_linter()` lints `sprintf()` and `gettextf()` calls when a constant string is passed to `fmt` (#2894, @Bisaloo).
+* `implicit_assignment_linter()` gains argument `allow_print` to disable lints for the use of `(` for auto-printing (#2919, @TimTaylor).


I think allow_implicit_print may be better, WDYT? My only hesitation is doubling "implicit" in the linter & argument names...

allow_bracket_print?

I'm already wary of implicit as a description as it already doesn't reflect how I think of my usage of this lint ... basically "stop people accidentally using <- in function calls". I'd prefer not to use the term more if possible.

Let's call it allow_paren_print

R/implicit_assignment_linter.R

codecov · 2025-08-04T18:29:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (2b70b52) to head (6181509).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2919   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files         129      129           
  Lines        7282     7285    +3     
=======================================
+ Hits         7227     7230    +3     
  Misses         55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AshesITR · 2025-08-11T16:58:37Z

Feels like a false positive to me - maybe we don't need an argument for this?

IINM this only removes top-level (x <- expr) lints, right?

TimTaylor · 2025-08-11T17:50:08Z

Feels like a false positive to me - maybe we don't need an argument for this?

That would be great but the custom print error message seems like it was a deliberate choice to lint for.

IINM this only removes top-level (x <- expr) lints, right?

I believe so (but take my agreement with caution as I deliberately avoided delving in to the XPath logic due to the pre-existing custom error).

AshesITR · 2025-08-11T18:43:14Z

Oh, I see, sorry.

* Fix false positive for null coalescing without else clause Signed-off-by: Emmanuel Ferdman <[email protected]> * cite in NEWS --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Michael Chirico <[email protected]>

* Partial fix for upcoming testthat release `expect_success()` and `expect_failure()` now test that you have exactly one success/failure and zero failures/successes. I can't quite figure out why the tests are still failing here; maybe it's something to do with recycling? I'm happy to help but I unfortunately I don't know enough about the lintr internals to figure out what's going wrong here. We're planning to submit testthat to CRAN on Nov 10. * simple delint * extract to helper for cyclo complexity * avoid testthat::expect() again * fail() needs return() --------- Co-authored-by: Michael Chirico <[email protected]>

…ib#2942)

* Don't lint T and F if followed by `[`. * Address review comments. * subsume into same expr[] as $ and @ --------- Co-authored-by: Michael Chirico <[email protected]>

Co-authored-by: Michael Chirico <[email protected]>

* Lint nrow, ncol, NROW and NCOL with logical expressions. * Address review comments. * Fix indentation. * tidy up tests --------- Co-authored-by: Michael Chirico <[email protected]>

* Make the message from cyclocomp_linter() more actionable. * Revert output changes. --------- Co-authored-by: Michael Chirico <[email protected]>

…-lib#2958)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

closes r-lib#2916

TimTaylor · 2025-10-29T11:01:42Z

Sorry, rebased in my branch and have messed this up. Will resubmit and reference this.

closes r-lib#2916 supersedes r-lib#2919

* feat: argument to disable linting of ( for auto-printing closes #2916 supersedes #2919 * update NEWS * tweak argument description

feat: argument to disable linting of ( for auto-printing

a845f25

closes r-lib#2916

MichaelChirico reviewed Aug 4, 2025

View reviewed changes

R/implicit_assignment_linter.R Show resolved Hide resolved

TimTaylor added 2 commits August 11, 2025 14:38

Merge branch 'r-lib:main' into bracket-print

8639bcd

lint: trailing newlines

f136901

MichaelChirico and others added 16 commits September 15, 2025 14:11

Merge branch 'main' into bracket-print

3cf8bc2

Merge branch 'main' into bracket-print

6181509

clarify reasoning for repeat{} vs. while(TRUE){}

825b1ee

Report a helpful error if linters_with_tags() specifies no tags. (r-l…

1af371c

…ib#2942)

Don't lint T and F if followed by [ (r-lib#2947)

ec9f159

* Don't lint T and F if followed by `[`. * Address review comments. * subsume into same expr[] as $ and @ --------- Co-authored-by: Michael Chirico <[email protected]>

init (r-lib#2948)

a321e59

Use expect_no_lint() instead of expect_lint(., NULL). (r-lib#2950)

dfe2255

Co-authored-by: Michael Chirico <[email protected]>

Lint nrow, ncol, NROW and NCOL with logical expressions (r-lib#2952)

3b0278d

* Lint nrow, ncol, NROW and NCOL with logical expressions. * Address review comments. * Fix indentation. * tidy up tests --------- Co-authored-by: Michael Chirico <[email protected]>

Remove duplicated condition from paren_body_linter(). (r-lib#2954)

473486f

Make the message from cyclocomp_linter() more actionable (r-lib#2953)

748de8e

* Make the message from cyclocomp_linter() more actionable. * Revert output changes. --------- Co-authored-by: Michael Chirico <[email protected]>

Note potential danger if argument can be NA in scalar_in_linter(). (r…

cdc91dd

…-lib#2958)

feat: argument to disable linting of ( for auto-printing

521b4b7

closes r-lib#2916

rename allow_print -> allow_paren_print

60f203e

TimTaylor closed this Oct 29, 2025

TimTaylor added a commit to TimTaylor/lintr that referenced this pull request Oct 29, 2025

feat: argument to disable linting of ( for auto-printing

f251b7e

closes r-lib#2916 supersedes r-lib#2919

TimTaylor mentioned this pull request Oct 29, 2025

feat: argument to disable linting of ( for auto-printing #2962

Merged

MichaelChirico pushed a commit that referenced this pull request Oct 29, 2025

feat: argument to disable linting of ( for auto-printing (#2962)

a6ac90b

* feat: argument to disable linting of ( for auto-printing closes #2916 supersedes #2919 * update NEWS * tweak argument description

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: argument to disable linting of `(` for auto-printing #2919

feat: argument to disable linting of `(` for auto-printing #2919

Uh oh!

TimTaylor commented Aug 4, 2025

Uh oh!

MichaelChirico Aug 4, 2025

Uh oh!

TimTaylor Aug 4, 2025

Uh oh!

MichaelChirico Sep 15, 2025

Uh oh!

Uh oh!

codecov bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

AshesITR commented Aug 11, 2025

Uh oh!

TimTaylor commented Aug 11, 2025 •

edited

Loading

Uh oh!

AshesITR commented Aug 11, 2025

Uh oh!

TimTaylor commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

feat: argument to disable linting of ( for auto-printing #2919

feat: argument to disable linting of ( for auto-printing #2919

Uh oh!

Conversation

TimTaylor commented Aug 4, 2025

Uh oh!

MichaelChirico Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

TimTaylor Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

MichaelChirico Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AshesITR commented Aug 11, 2025

Uh oh!

TimTaylor commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AshesITR commented Aug 11, 2025

Uh oh!

TimTaylor commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

feat: argument to disable linting of `(` for auto-printing #2919

feat: argument to disable linting of `(` for auto-printing #2919

codecov bot commented Aug 4, 2025 •

edited

Loading

TimTaylor commented Aug 11, 2025 •

edited

Loading